Skip to content

chore(devDeps): update dependencies #456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 22, 2021
Merged

chore(devDeps): update dependencies #456

merged 1 commit into from
Aug 22, 2021

Conversation

MichaelDeBoey
Copy link
Member

CI is failing because ts-jest changed their peerDependencies (which should have been a major release)

@MichaelDeBoey MichaelDeBoey added the dependencies Pull requests that update a dependency file label Aug 21, 2021
@MichaelDeBoey MichaelDeBoey requested a review from Belco90 August 21, 2021 17:16
@MichaelDeBoey MichaelDeBoey enabled auto-merge (squash) August 21, 2021 17:19
Belco90
Belco90 approved these changes Aug 22, 2021
View reviewed changes
Copy link
Member

@Belco90 Belco90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3rd time this year we get CI broken because of new package version released introduced unexpected breaking changes.

Thinking seriously now about fixing versions in package.json

@MichaelDeBoey MichaelDeBoey merged commit e1f39fc into main Aug 22, 2021
@MichaelDeBoey MichaelDeBoey deleted the update-dependencies branch August 22, 2021 14:16
@MichaelDeBoey
Copy link
Member Author

MichaelDeBoey commented Aug 22, 2021 •
edited
Loading

I don't think we should fix versions in our package.json as CI failing is happening really rarely.
ts-jest should have made kulshekhar/ts-jest#2816 a breaking change.

Fixing versions will break the dedupe feature too.

Edit: it appears ts-jest doesn't apply SemVer, so we should fix that version I think
https://github.com/kulshekhar/ts-jest#versioning

@MichaelDeBoey MichaelDeBoey mentioned this pull request Aug 22, 2021
Merged
@github-actions
Copy link

🎉 This PR is included in version 4.12.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Belco90 Belco90 Belco90 approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MichaelDeBoey @Belco90